Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove MSVC 19.39 downgrade, fix crashes caused by the new version #55

Merged
merged 1 commit into from
Nov 16, 2024

Conversation

estebanfer
Copy link
Contributor

Adjusted some Conan settings to enable the _DISABLE_CONSTEXPR_MUTEX_CONSTRUCTOR on the libraries used, preventing the crash at startup caused by them

@estebanfer
Copy link
Contributor Author

estebanfer commented Sep 18, 2024

Changes summary:

In CMakeLists.txt:

add_compile_definitions(_DISABLE_CONSTEXPR_MUTEX_CONSTRUCTOR) Adds the define to the playlunky build (conan packages unaffected).

In cmake/conan.cmake:

tools.build:defines=["_DISABLE_CONSTEXPR_MUTEX_CONSTRUCTOR"] add the define to the packages that will be provided by connan

tools.info.package_id:confs=["tools.build:defines"] Makes conan to include the defines added to the package id of the used libraries, resulting in it not reusing cached packages that weren't built with the necessary define.

For the rest it's pretty self-explainatory

@estebanfer
Copy link
Contributor Author

To make sure it won't cause a crash on the nightly, I enabled actions in my fork and tested it: https://github.com/estebanfer/Playlunky/releases/tag/nightly

@Malacath-92 Malacath-92 merged commit 4d69e4f into spelunky-fyi:main Nov 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants